[Webkit-unassigned] [Bug 65192] [EFL] Do not crash if the Cairo surface cannot be created.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 2 05:41:07 PDT 2011


--- Comment #11 from Raphael Kubo da Costa <kubo at profusion.mobi>  2011-09-02 05:41:07 PST ---
(In reply to comment #10)
> I don't know exactly how your theme cache works, but it seems that if you should already be checking whether the widget changes size each time you draw. You'd just need to add one more condition determining whether or not the clip region has moved or changed size. I'm not sure how feasible that is.

After spending some time on this, it looks like implementing this suggestion could be feasible, but would require quite some effort. On the one hand, Edje (which actually renders the theme) has a hardcoded limit of 20000x20000 pixels for a widget's dimensions; on the other hand, the way RenderThemeEfl is currently implemented makes it a bit difficult to track the clipping region and decide where exactly in the cairo context to paint the rendered element (when scrolling, scaling and other things are taken into account it becomes even harder).

For now, I think it's OK to just not display elements which are too big (a 1-month-old GtkLauncher build I have here just displays the top of the textarea in the mentioned testcase, and my distro's Chromium displays mostly garbage after some point too).

I'm submitting a new patch with a better heuristic in a few minutes.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list