[Webkit-unassigned] [Bug 67254] [Qt][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=67254


Andras Becsi <abecsi at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #105939|commit-queue?               |commit-queue-
               Flag|                            |




--- Comment #9 from Andras Becsi <abecsi at webkit.org>  2011-09-02 04:47:43 PST ---
(From update of attachment 105939)
View in context: https://bugs.webkit.org/attachment.cgi?id=105939&action=review

I've CC'd Ossy who cares about this.

The change looks good to me except that you change the fallback behavior compared to the original approach.

> Tools/DumpRenderTree/qt/LayoutTestControllerQt.cpp:257
> +    return url;

I think this should be "return QDir::toNativeSeparators(url);" so that the fallback case matches the previous behavior.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.