[Webkit-unassigned] [Bug 67458] Generate a WebKitCSSMatrix constructor of V8 using the IDL 'Constructor' extended attribute

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 2 04:05:54 PDT 2011


--- Comment #6 from anton muhin <antonm at chromium.org>  2011-09-02 04:05:54 PST ---
(From update of attachment 106074)
View in context: https://bugs.webkit.org/attachment.cgi?id=106074&action=review

Overall, won't WithUndefinedOrNullCheck attribute do what you are looking for?

In general I am not sure (but I didn't check) that the current implementation correctly processes null, but if your policy regarding null is different, I would still suggest adding another policy to V8Parameter instead of brand-new attribute.

May you give it a try?

And probably add a test to see what happens with new WebKitCSSMatrix(null)

> Source/WebCore/bindings/v8/V8Binding.h:390
> +            if (m_v8Object.IsEmpty())

I would put it differently: if (m_v8Object.IsEmpty()) {  setString(String(); return true; } and remove all special cases below.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list