[Webkit-unassigned] [Bug 66027] Implementation for "nav-up" "nav-down" "nav-left" "nav-right" properties in CSS3-UI module

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=66027


kyounga <kyounga.ra at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #106113|                            |review?
               Flag|                            |




--- Comment #5 from kyounga <kyounga.ra at gmail.com>  2011-09-02 04:00:14 PST ---
Created an attachment (id=106113)
 --> (https://bugs.webkit.org/attachment.cgi?id=106113&action=review)
initial patch for review.

I know css-style are discussing on using ID selector as CSS value.
just made an initial implementation only for review.

There are several issues to be discussed in my patch
1. Changed CSSGrammar.y
    - Added IDSEL as a value, checked for #15360 issue (IDSEL was removed by this issue.)
2. Added a new class member to RenderStyle, instead of pointer or smart pointer.
    - Is it memory waste? less memory fragmentation? good performance? 
    - I think that this property won't be used frequently but if it is used once, it may be used frequently in one page.

Simple unit-tests are completed.
- no "nav-*" property.
- simple "nav-*" property from CSS3-UI example.
- scrollable page.
- inherit value
- invalid target name = no work.
- target name = between two frames.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.