[Webkit-unassigned] [Bug 66852] [Qt] [PATCH] Improve the handling of $project in webkitdirs.pm

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=66852





--- Comment #4 from Andras Becsi <abecsi at webkit.org>  2011-09-02 03:23:26 PST ---
The change looks good to me except that I agree with Balazs, adding an extra option like --lib-only or something similar would be a good improvement and would make the lives of developers easier.
Also, every patch needs a ChangeLog, you can read about that on http://trac.webkit.org/wiki/QtWebKitContrib#Submittingapatch

Please submit an updated patch.

(In reply to comment #1)
> There were two typos in my initial submission. The tests performed and their results actually were:
> 
> I have tested this patch by checking that the following work:
> * build-jsc -> builds JavaScriptCore only
> * build-webkit -> builds WebKit libraries, Tools, examples
> * build-webkit with project type set to "" in the call to buildQMakeQtProject() -> builds WebKit libraries only

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.