[Webkit-unassigned] [Bug 67269] Provides a stand alone CSSWG reftest runner which can be used internally.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=67269


Hayato Ito <hayato at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #105948|review?                     |review-
               Flag|                            |




--- Comment #6 from Hayato Ito <hayato at chromium.org>  2011-09-01 18:15:57 PST ---
(From update of attachment 105948)
Hi Ai-san. Thank you for addressing comments!
Could you address some minor comments again? Sorry for the back and forth.

I don't think we need a comprehensive unittest for this type of script because this test runner can be used only internally.
So we could land this patch after you addressing minor comments and Hamaji-san reviews and give r+ to a next patch. 


View in context: https://bugs.webkit.org/attachment.cgi?id=105948&action=review

> Tools/Scripts/webkitpy/layout_tests/reftests/test_csswg_reftest.py:72
> +            return

Could you remove this line? We don't need 'return' here.

> Tools/Scripts/webkitpy/layout_tests/reftests/test_csswg_reftest.py:101
> +                self.test_files[test_file].crash = True

You might want to replace L100-101 with one line as:
    self.test_files[test_file].crash = output.crash

> Tools/Scripts/webkitpy/layout_tests/reftests/test_csswg_reftest.py:137
> +            if self.test_files[test_file].crash:

Could you print a message to notify a crash?
like:
   print "test_file: %s is crashed." % test_file

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.