[Webkit-unassigned] [Bug 67453] REGRESSION(r94274): FormManagerTest.PreviewForm and FillFormNonEmptyField fail on chromium

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 1 16:33:51 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=67453


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |InChromiumBugs
           Priority|P2                          |P1




--- Comment #1 from Ryosuke Niwa <rniwa at webkit.org>  2011-09-01 16:33:51 PST ---
http://code.google.com/p/chromium/issues/detail?id=95048

Comment 6 by isherman at chromium.org, Today (2 hours ago)
It looks like the problem is that setSuggestedValue() is not updating the renderer.

> All these auto-fill tests are super annoying.  Someone should make a corresponding WebKit test so that I don't have to debug chromium.  I'll debug it tomorrow.

Or you could add layout tests along with your fix ;)  There aren't a lot of existing layout tests in this area because DRT only recently gained the necessary infrastructure to write such tests.

Comment 8 by rniwa at chromium.org, Today (2 hours ago)
Indeed. I bet we just need to replace the call to updateFromElement by a call to updateInnerTextValue in HTMLInputElement::setSuggestedValue.
http://trac.webkit.org/browser/trunk/Source/WebCore/html/HTMLInputElement.cpp#L1066

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list