[Webkit-unassigned] [Bug 66498] Typesetting features need not force complex for single-character runs

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=66498


James Robinson <jamesr at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jamesr at chromium.org




--- Comment #11 from James Robinson <jamesr at chromium.org>  2011-09-01 11:50:10 PST ---
On Chromium Mac on Snow Leopard this patch caused the text metrics on fast/text/international/vertical-text-glyph-test.html to change very, very slightly.  Here's the text diff:

--- /b/build/slave/Webkit_Mac10_6__CG__dbg_/build/layout-test-results/fast/text/international/vertical-text-glyph-test-expected.txt 
+++ /b/build/slave/Webkit_Mac10_6__CG__dbg_/build/layout-test-results/fast/text/international/vertical-text-glyph-test-actual.txt 
@@ -1,8 +1,8 @@
-layer at (0,0) size 785x634
+layer at (0,0) size 785x635
   RenderView at (0,0) size 785x600
-layer at (0,0) size 785x634
-  RenderBlock {HTML} at (0,0) size 785x634
-    RenderBody {BODY} at (8,21) size 769x605
+layer at (0,0) size 785x635
+  RenderBlock {HTML} at (0,0) size 785x635
+    RenderBody {BODY} at (8,21) size 769x606
       RenderBlock {P} at (0,0) size 769x32
         RenderText {#text} at (0,5) size 161x21
           text run at (0,5) width 161: "Simple text path"
@@ -15,8 +15,8 @@
       RenderBlock {P} at (0,320) size 769x32
         RenderText {#text} at (0,5) size 181x21
           text run at (0,5) width 181: "Complex text path"
-      RenderBlock (anonymous) at (0,373) size 769x232
-        RenderBlock {SPAN} at (0,0) size 32x223
-          RenderText {#text} at (5,0) size 21x223
-            text run at (5,0) width 223: "string\x{300C}\x{3042}\x{3001}\x{5909}\x{3063}\x{FF01}\x{300D}\x{3002}"
+      RenderBlock (anonymous) at (0,373) size 769x233
+        RenderBlock {SPAN} at (0,0) size 32x224
+          RenderText {#text} at (5,0) size 21x224
+            text run at (5,0) width 224: "string\x{300C}\x{3042}\x{3001}\x{5909}\x{3063}\x{FF01}\x{300D}\x{3002}"
         RenderText {#text} at (0,0) size 0x0

This also changes the pixel output slightly - the text all renders the same, but the scrollbar looks different because the scrollable area is 1px taller.  I'm planning to rebaseline since this looks harmless, but since the comments indicate that this should not have changed any layout posting as an FYI.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.