[Webkit-unassigned] [Bug 67341] Scissor rect optimization for chromium compositor

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=67341





--- Comment #4 from Shawn Singh <shawnsingh at chromium.org>  2011-09-01 11:19:55 PST ---
(From update of attachment 105864)
View in context: https://bugs.webkit.org/attachment.cgi?id=105864&action=review

> Source/WebCore/platform/graphics/chromium/LayerChromium.cpp:118
> +void LayerChromium::setNeedsCommitBecausePropertyChanged(bool layerHasMoved)

Actually, I think we can get rid of this boolean switch.  The only difference was whether we need to draw both the "old" and "new" locations of the layer because it moved, or just the existing location of the layer.   In the latter case, the "old" and "new" locations are the same.   So, it seems better to avoid this error-prone boolean flag.

> Source/WebCore/platform/graphics/chromium/cc/CCLayerImpl.h:81
> +    const FloatRect& dirtyRect() { return m_dirtyRect; }

Whoops, I intended to rename this accessor and member variable as "repaintRect" instead of "dirtyRect".   Also need to make the accessor const.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.