[Webkit-unassigned] [Bug 64297] [Qt][WK2] Add the Web Inspector to WebKit2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=64297





--- Comment #87 from Genisim <genisim at yahoo.com>  2011-09-01 11:01:31 PST ---
(In reply to comment #82)
> (From update of attachment 105850 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=105850&action=review
> 
> How can a patch go through so many iterations and still so so wrong?
> 
> > Source/WebKit2/UIProcess/API/qt/qdesktopwebview.h:53
> > +namespace WebKit {
> > +    class WebInspectorProxy;
> > +}
> 
> We don't indent in namespaces.
> 


 1. no namespace brackets generates follow errors

UIProcess/API/qt/qdesktopwebview.h:124: error: ‘WebInspectorProxy’ in namespace ‘WebKit’ does not name a type

/scratchbox/users/genisim/home/genisim/swork/webkit_upstream/webkit_trunk/trunk_qt5/Source/WebKit2/UIProcess/API/qt/qdesktopwebview.h:124: error: friend declaration does not name a class or function

 2. I got suggestions don't use includes and use classes forward declarations.

 3. If it is a rule - "don't indent in namespaces", will be good clean a code.
If you check code, you will find many places with "indent in namespaces".
Or maybe it is a special exceptions - here allow to use and here not.

> > Source/WebKit2/UIProcess/API/qt/qdesktopwebview.h:74
> > +    void setDeveloperExtrasEnabled(bool);
> > +    void setWebInspectorEnabled(bool);
> 
> We don't have settings on the QDesktopWebView.  That is just plain wrong.
> 
> > Source/WebKit2/UIProcess/qt/QtWebPageProxy.cpp:743
> > +void QtWebPageProxy::setDeveloperExtrasEnabled(bool enable)
> > +{
> > +    m_webPageProxy->pageGroup()->preferences()->setDeveloperExtrasEnabled(enable);
> > +}
> 
> This totally doesn't belong here

It is a long history for this patch and many different variants:
  1. API calling directly from app MiniBrowser (declined)
  2. Was asking - maybe need create new class (declined)
  3. Was calling set... into qdesktopwebview and qtouchwebview (declined. Make sense to me, because from both views calling same API. Maybe make sense if API will be different)

Please come to consensus and send me comments (summary) which is accepted by
all of you (I understand how difficult do this, but please try)

All platforms are using Web Inspector - MAC, Win, and I hope Qt will join to platforms which using Web Inspector too.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.