[Webkit-unassigned] [Bug 67254] [Qt][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=67254





--- Comment #8 from Jarred Nicholls <jarred at sencha.com>  2011-09-01 04:34:04 PST ---
(In reply to comment #6)
> The code looks good otherwise but I have no verified if the patch is the right solution :)
> 
> The win port implementation is quite different, and not specific to /tmp: http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/win/LayoutTestControllerWin.cpp#L674

I've read the win port's implementation, and obviously it's based on a Cygwin environment.  That's not good enough.  And that would still mean the NRWT would have to create a symlink into that environment, which it doesn't right now.

Dirk Pranke from Google and I are on the same page, that DRT/WTR should be smart and take care of remapping these URLs to a local URL that's derived by the running process' location.  NRWT shouldn't have to know to create a symlink or be tied to a *nix environment in order to function properly.

Thus, this is what Chromium does.  See some of the relevant code parts here: http://pastie.org/pastes/2464106  The LayoutTests folder is derived by the running exec's location.

Changing the tests is also not good, because it will lower the integrity of the test; and have to be absolute URLs for the security tests where we're attempting to load local resources from a remote domain.

Let me know if you have a better idea :)  A better generic solution would be a configurable hash of remappable URL paths that DRT/WTR can work with, instead of this static solution - but this is a good stop gap I think.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.