[Webkit-unassigned] [Bug 38054] [Qt] Build dependency problems

Thu Sep 1 02:32:23 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=38054

Jocelyn Turcotte <jocelyn.turcotte at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #105925|review?                     |review-
               Flag|                            |

--- Comment #10 from Jocelyn Turcotte <jocelyn.turcotte at nokia.com>  2011-09-01 02:32:23 PST ---
(From update of attachment 105925)
Looks like this should fix it, simple and efficient!
One thing that should be changed is to move the CONFIG(compute_defaults) { } part in Source/WebCore/features.pri to the end of the file and a comment should be added to say that nothing should be placed after it.

For example right now, since ENABLE_XHTMLMP is defined after the compute_defaults part, changing it won't trigger a clean build. Beside this it LGTM.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.