[Webkit-unassigned] [Bug 64297] [Qt][WK2] Add the Web Inspector to WebKit2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=64297


Kenneth Rohde Christiansen <kenneth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #105850|review?                     |review-
               Flag|                            |




--- Comment #82 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2011-09-01 02:27:38 PST ---
(From update of attachment 105850)
View in context: https://bugs.webkit.org/attachment.cgi?id=105850&action=review

How can a patch go through so many iterations and still so so wrong?

> Source/WebKit2/UIProcess/API/qt/qdesktopwebview.h:53
> +namespace WebKit {
> +    class WebInspectorProxy;
> +}

We don't indent in namespaces.

> Source/WebKit2/UIProcess/API/qt/qdesktopwebview.h:74
> +    void setDeveloperExtrasEnabled(bool);
> +    void setWebInspectorEnabled(bool);

We don't have settings on the QDesktopWebView.  That is just plain wrong.

> Source/WebKit2/UIProcess/qt/QtWebPageProxy.cpp:743
> +void QtWebPageProxy::setDeveloperExtrasEnabled(bool enable)
> +{
> +    m_webPageProxy->pageGroup()->preferences()->setDeveloperExtrasEnabled(enable);
> +}

This totally doesn't belong here

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.