[Webkit-unassigned] [Bug 70277] MoveSelectionCommand::doApply hits an assertion when dragging text without a range selection

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=70277


Devdatta <pwjd73 at motorola.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pwjd73 at motorola.com




--- Comment #5 from Devdatta <pwjd73 at motorola.com>  2011-10-31 23:50:26 PST ---
(In reply to comment #4)
> (From update of attachment 113130 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=113130&action=review
> 
> > LayoutTests/fast/events/drag-link.html:17
> > +    function dragElement(srcElement, destElement) 
> > +    {
> 
> As I said, I don't think we want to indent the entire script like this.
> 
Sorry I misinterpreted the comment. I will remove one level indentation in the script.

> > LayoutTests/fast/events/drag-link.html:34
> > +
> > +    document.getElementById("result").innerHTML = "PASS";
> 
> This test always passes?
This test results into an assert if the patch is not applied, and if the drag-drop fails the 'Test link' will not be added into the actual result. Thus I think the result div is redundant and can be removed.

Also, I believe this will fix bug 61008 as well.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.