[Webkit-unassigned] [Bug 65542] Need support for dirname attribute

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=65542


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #111386|commit-queue?               |
               Flag|                            |




--- Comment #9 from Eric Seidel <eric at webkit.org>  2011-10-31 14:21:26 PST ---
(From update of attachment 111386)
View in context: https://bugs.webkit.org/attachment.cgi?id=111386&action=review

> Source/WebCore/html/HTMLTextAreaElement.cpp:177
> +    if (fastHasAttribute(dirnameAttr))

is fastHasAttribute correct to use?  What's the difference between fast and normal hasAttribute?

> Source/WebCore/html/HTMLTextAreaElement.cpp:178
> +        encoding.appendData(fastGetAttribute(dirnameAttr).string(), dirNameAttributeFormData());

Why do we need the explicit .string() call?  AtomicStings and Strings convert implicitly jsut fine.

> Source/WebCore/html/HTMLTextFormControlElement.cpp:575
> +    String dir;

No need for a local, just return once you know the value.

> Source/WebCore/html/HTMLTextFormControlElement.cpp:578
> +    TextDirection textDirection = directionalityIfhasDirAutoAttribute(isAuto);

Ifhas?  Bad caps?

> LayoutTests/fast/forms/form-dirname-attribute-expected.txt:4
> +PASS input.dirName is "Hello"
> +PASS textArea.dirName is "Hello"

We're suppose to ignore values other than rtl/ltr, correct?  Do we do that at submission time or at parse time?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.