[Webkit-unassigned] [Bug 71202] DFG OSR exits should add to value profiles

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 31 13:12:43 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=71202





--- Comment #6 from Filip Pizlo <fpizlo at apple.com>  2011-10-31 13:12:44 PST ---
(In reply to comment #5)
> (From update of attachment 113023 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=113023&action=review
> 
> > Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:642
> > -    speculationCheck(m_jit.branchTest32(MacroAssembler::Zero, scratchReg));
> > +    speculationCheck(JSValueRegs(), NoNode, m_jit.branchTest32(MacroAssembler::Zero, scratchReg));
> 
> Might be nice to be able to record that we're seeing ropes here -- if we are there's no point in planting an inline character access as we currently do

Or better yet, drop a call to deropification and have the CFA realize that after this call, it's no longer a rope.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list