[Webkit-unassigned] [Bug 70395] REGRESSION: rtl horizontal scrollbar / resize bug - Body shifts on resize when scrolled all the way to the left

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=70395





--- Comment #16 from Tony Chang <tony at chromium.org>  2011-10-31 09:54:01 PST ---
(In reply to comment #15)
> (In reply to comment #14)
> > (In reply to comment #13)
> > > (From update of attachment 112805 [details] [details] [details])
> > > I don't know this code well enough to review this patch, however, I have 2 suggestions:
> > > 1) Do a refactor patch first that adds the getter methods and makes the member variables private.  This will make the patch much smaller.
> > 
> > Good suggestion!
> 
> BTW, changing m_scrollOrigin to be private is due to the introduction of m_scrollOriginChanged.
> the setter will update m_scrollOriginChanged as well. If there is a better way to not introduce m _scrollOriginChanged, m_scrollOrigin does not need to be private.

I think it's ok to make m_scrollOrigin private in a refactor patch and add m_scrollOriginChanged in the bug fix patch.

If having m_scrollOriginChanged is unavoidable, maybe name it to be more specific like m_scrollOriginChangedDuringResize or something.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.