[Webkit-unassigned] [Bug 71128] Select multiple options with mouse drag in Select element.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=71128





--- Comment #10 from Ryosuke Niwa <rniwa at webkit.org>  2011-10-31 06:38:00 PST ---
(In reply to comment #9)
> Presently we return if don't find a renderer for targetNode in EventHandler::handleMouseDraggedEvent() :
> 
> if (event.event().button() != LeftButton || !targetNode || !targetNode->renderer())
> 
> When we do a drag on the option element we don't get a renderer but as its parent(select) element has a renderer and it can scroll, we can allow auto scroll for parent.

Then we must be detecting this specific case, not always fallback to the parent node.

> In short, as we want to autoscroll on any renderer that is autoscrollable in its tree, allow it even when present node does not have renderer but its parent has.

That seems wrong. On one hand, we need a justification as to why it's okay to fallback to its parent. In the case of option and select, it's clear but I'm not convinced that it's always okay for other cases.

On the other hand, it's also unclear to me why we only need to care about the parent node if we're applying this to any node. Why, for example, don't we go up the tree until we find an ancestor with renderer?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.