[Webkit-unassigned] [Bug 71191] The DFG inliner should not flush the callee

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=71191


Oliver Hunt <oliver at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #112997|review?                     |review+
               Flag|                            |




--- Comment #2 from Oliver Hunt <oliver at apple.com>  2011-10-30 15:21:35 PST ---
(From update of attachment 112997)
View in context: https://bugs.webkit.org/attachment.cgi?id=112997&action=review

It would be nice is we could elide the argument flushing when we can prove no OSRs will happen

> Source/JavaScriptCore/bytecode/CodeOrigin.h:81
>      unsigned stackOffset;
> -    unsigned calleeVR;
> +    WriteBarrier<JSFunction> callee;
>      CodeOrigin caller;

can we move stackOffset down the struct? changing from an unsigned to a pointer should increase alignment requirements so i think this ends up increasing the struct size by 12 bytes rather than 4

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.