[Webkit-unassigned] [Bug 70898] Range sliders and spin buttons don't work with multi-columns

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=70898


mitz at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #112842|review?                     |review-
               Flag|                            |




--- Comment #6 from mitz at webkit.org  2011-10-28 07:56:40 PST ---
(From update of attachment 112842)
View in context: https://bugs.webkit.org/attachment.cgi?id=112842&action=review

> Source/WebCore/rendering/RenderBoxModelObject.cpp:2596
> +    LayoutSize containerOffset = offsetFromContainer(o, LayoutPoint());

offsetFromContainer() already calls adjustForColumns(). You should just pass the actual point instead of the zero point so that it does the right thing, instead of replicating adjustForColumns() below (your replicated code is also missing the check for the progression axis). All you probably need to do is move the offsetFromContainer() override from RenderBox to RenderBoxModelObject.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.