[Webkit-unassigned] [Bug 71101] Stylebot should not complain about a RefPtr argument passed by pointer (RefPtr<...>*)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=71101





--- Comment #2 from Alexander Pavlov (apavlov) <apavlov at chromium.org>  2011-10-28 03:57:17 PST ---
(In reply to comment #1)
> Apparently this use is not actually legitimate.
> 
> https://bugs.webkit.org/show_bug.cgi?id=69366

Yes, that makes sense, since the pointer-vs-reference decision was changed recently. In my case, a change added a parameter to a method signature, and this method already had a RefPtr<..>* output parameter. Fixing this particular stylebot failure implied touching A LOT of this method call sites (I was adding a parameter with a default value) and fixing the method body instead of just modifying a dozen of lines for my original change. I agree, however, that this is a challenge to balance the stylebot output against the obsolete-styled code.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.