[Webkit-unassigned] [Bug 70814] [GTK] Add webkit_web_view_get_uri() to WebKit2 GTK+ API

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 27 23:57:50 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=70814


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mrobinson at webkit.org




--- Comment #6 from Martin Robinson <mrobinson at webkit.org>  2011-10-27 23:57:50 PST ---
(In reply to comment #5)

> As long as other tests use the new methods in WebViewTest it will work, I added it to the fixture on purpose. LoadTrackingTest inherits from WebViewTest so any test using LoadTRackingTest will have those methods available. Estimated progress is also checked in the fixture, for example. One advantage of testing global stuff in the fixture is that it will be checked for other tests that are not thought to test it. 

There's an interesting tradeoff because maybe you cover some corner case that you didn't think of when you have the assertions in the fixture. On the other hand that becomes like a "hidden" test. You also have the issue where if it fails, every single test starts failing and you don't know where to start.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list