[Webkit-unassigned] [Bug 70914] [EFL] build on macosx does not work for various small reasons

Thu Oct 27 19:24:16 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=70914

Gyuyoung Kim <gyuyoung.kim at samsung.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #112651|                            |review-
               Flag|                            |

--- Comment #7 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2011-10-27 19:24:16 PST ---
(From update of attachment 112651)
View in context: https://bugs.webkit.org/attachment.cgi?id=112651&action=review

You miss ChangeLog for this patch. You can make ChangeLog via Tools/Script/prepare-ChangeLog script.

>> Source/WebCore/platform/cairo/WidgetBackingStore.h:27
>> +#include <cairo/cairo.h>
> 
> Alphabetical sorting problem.  [build/include_order] [4]

Please run Tools/Script/check-webkit-style script before submitting this patch.

> Source/cmake/FindEFL.cmake:7
> +  eina>=1.0.99

Why do you reduce efl library version ?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.