[Webkit-unassigned] [Bug 70634] Mark GraphicsLayers as opaque when possible

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=70634





--- Comment #29 from Simon Fraser (smfr) <simon.fraser at apple.com>  2011-10-27 17:17:55 PST ---
(In reply to comment #28)
> (In reply to comment #27)
> > (In reply to comment #25)
> > > Regarding testing:
> > > 
> > > I think the right way to test this is to add contentsOpaque to the output of GraphicsLayer::dumpProperties().  However this change alone which break and require rebaselining a *lot* of layout tests.
> > 
> > No, not if you only print it out when it has the non-default value.
> ...
> > 
> > No need for any of this. Just print out contentsOpaque when it's true.
> 
> The default value is non-opaque, since we want to assume things blend if we're not sure. But I imagine most tests actually actually use opaque layers, and the root layer should always be opaque. How come this won't make all these tests fail?

I think we omit the root layer from the layer dump to avoid platform differences. You're right in that some existing tests may have opaque layers, but that's a progression we'd like to know about. You'll just have to land new results.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.