[Webkit-unassigned] [Bug 70634] Mark GraphicsLayers as opaque when possible

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=70634


Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1




--- Comment #27 from Simon Fraser (smfr) <simon.fraser at apple.com>  2011-10-27 16:58:25 PST ---
(In reply to comment #25)
> Regarding testing:
> 
> I think the right way to test this is to add contentsOpaque to the output of GraphicsLayer::dumpProperties().  However this change alone which break and require rebaselining a *lot* of layout tests.

No, not if you only print it out when it has the non-default value.

> First I'll say my own thoughts:  Currently LayoutTestController.layoutTreeAsText(bool) takes an argument to show debug info.  If we extend this to allow setting various flags for layoutTreeAsText(), we can enable "contentsOpaque" in the DRT output only when we want it, and expose this to tests.
> 
> To do this:
> - Remove boolean argument to layoutTreeAsText().
> - Add setLayerTreeAsTextFlag(string, bool) to LayoutTestController.
>   - Eventually this string is parsed to a value from the enum LayerTreeAsTextBehaviourFlags in GraphicsLayer.h
> 
> The big win here is that we can use DRT output to test this property nicely, without having to rebaseline any other tests.  If/when future properties are flipped on in GraphicsLayer or equivalent, this could pay off there also.
> 
> I will attach a patch to give an idea what this would look like.

No need for any of this. Just print out contentsOpaque when it's true.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.