[Webkit-unassigned] [Bug 71042] New: Don't use GOwnPtr for ref-counted objects

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=71042

           Summary: Don't use GOwnPtr for ref-counted objects
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: WebKit Gtk
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: jonathon at quotidian.org
                CC: gns at gnome.org



Jonathon Jongsma (jonner) <jonathon at quotidian.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #112716|                            |review?
               Flag|                            |


Created an attachment (id=112716)
 --> (https://bugs.webkit.org/attachment.cgi?id=112716&action=review)
patch to use GRefPtr instead

In a few places in the gstreamer media player implementation, GOwnPtr is used with ref-counted objects (GstElement, etc).  The implementation is basically correct, but the semantics are confusing because a GOwnPtr is meant to indicate exclusive ownership of memory, whereas ref-counted objects have shared ownership by definition.  Changing to use GRefPtr makes things a bit more verbose (due to not having the outPtr() method), but I think it is more correct and less confusing.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.