[Webkit-unassigned] [Bug 70995] The GC should be parallel

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=70995


WebKit Review Bot <webkit.review.bot at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |webkit.review.bot at gmail.com




--- Comment #3 from WebKit Review Bot <webkit.review.bot at gmail.com>  2011-10-27 00:44:37 PST ---
Attachment 112647 did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/JavaScriptCore/heap/SlotVisitor.h:38:  The parameter name "heap" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/heap/MarkStack.cpp:165:  Should have a space between // and comment  [whitespace/comments] [4]
Source/JavaScriptCore/heap/MarkStack.cpp:183:  Should have a space between // and comment  [whitespace/comments] [4]
Source/JavaScriptCore/heap/MarkStack.cpp:189:  This { should be at the end of the previous line  [whitespace/braces] [4]
Source/JavaScriptCore/heap/MarkStack.cpp:212:  Should have a space between // and comment  [whitespace/comments] [4]
Source/JavaScriptCore/heap/MarkStack.cpp:220:  Should have a space between // and comment  [whitespace/comments] [4]
Source/JavaScriptCore/heap/MarkStack.cpp:229:  Should have a space between // and comment  [whitespace/comments] [4]
Source/JavaScriptCore/heap/MarkStack.cpp:234:  Should have a space between // and comment  [whitespace/comments] [4]
Source/JavaScriptCore/heap/MarkStack.h:125:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Source/JavaScriptCore/heap/Heap.cpp:695:  Should have a space between // and comment  [whitespace/comments] [4]
Source/JavaScriptCore/heap/Heap.cpp:697:  Should have a space between // and comment  [whitespace/comments] [4]
Source/JavaScriptCore/heap/Heap.cpp:801:  Should have a space between // and comment  [whitespace/comments] [4]
Source/JavaScriptCore/heap/Heap.cpp:803:  Should have a space between // and comment  [whitespace/comments] [4]
Total errors found: 13 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.