[Webkit-unassigned] [Bug 68789] Unable to embed a flash plug-in using an <embed> element with mime type "application/octet-stream"

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=68789


Andy Estes <aestes at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #111913|review?                     |review-
               Flag|                            |




--- Comment #30 from Andy Estes <aestes at apple.com>  2011-10-26 21:54:05 PST ---
(From update of attachment 111913)
View in context: https://bugs.webkit.org/attachment.cgi?id=111913&action=review

Not all ports go through one of the two code paths you modified. For instance, I believe WebKit1 on the Mac will still show the missing plug-in indicator after this patch. r- because of that. I have other comments below.

> Source/WebCore/ChangeLog:3
> +        Bug 68789: Using src url extension when there is no plugin to handle specified mimetype in type attribute of embed element.

I'd just use the bug title here.

> Source/WebCore/ChangeLog:11
> +        (WebCore::PluginDatabase::findPlugin):Modifed to make use of src extension to find matching plugin when no plugin is found for specified mime type.

There should be a space between the colon and the word modified. You also misspelled modified.

> Source/WebKit2/ChangeLog:3
> +        Bug 68789: Using src url extension when there is no plugin to handle specified mimetype in type attribute of embed element.

I'd just use the bug title here.

> LayoutTests/ChangeLog:9
> +        * plugins/invalid-mime-with-valid-extension-shows-missing-plugin.html: Test should pass if the plugin is resolved based on extension.

This test is now incorrectly named based on what we expect it to do.

> LayoutTests/ChangeLog:11
> +        * plugins/unsupportedmime-supportedextension.html: Added.

How is this test different than the one above? They both seem to verify that a plug-in loads, just using different TestNetscapePlugIn mechanisms.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.