[Webkit-unassigned] [Bug 70215] Generate WebKitCSSMatrix constructor for JSC by [Constructor] IDL

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=70215


Sam Weinig <sam at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #111545|review?                     |review-
               Flag|                            |




--- Comment #4 from Sam Weinig <sam at webkit.org>  2011-10-26 18:29:55 PST ---
(From update of attachment 111545)
View in context: https://bugs.webkit.org/attachment.cgi?id=111545&action=review

We should not be special casing an empty JSValue.  If you get one of these, something is probably wrong.

> Source/JavaScriptCore/runtime/JSString.h:712
> +        if (isEmpty())
> +            return UString();

This is wrong.  The empty value JSValue should be treated like a null pointer, and you should never call functions on it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.