[Webkit-unassigned] [Bug 70810] nameNodeListCache should be invalidated when name attribute changes/modified.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=70810


Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|nameNodeListCache should be |nameNodeListCache should be
                   |invalidate when name        |invalidated when name
                   |attribute changes/modified. |attribute changes/modified.
                 CC|                            |darin at apple.com




--- Comment #7 from Alexey Proskuryakov <ap at webkit.org>  2011-10-26 13:38:48 PST ---
Hmm, I can't easily tell if the fix is in the right place, deferring to other reviewers. There is a lot of fishy stuff going on - an first of all, the existing code in Node::dispatchSubtreeModifiedEvent() seems misplaced. A function that's named to dispatch an unimportant deprecated event shouldn't be doing super important work like flushing caches!

Interestingly, if the element doesn't have a name attribute yet, DOMSubtreeModified gets dispatched through NamedNodeMap::addAttribute(). And adding class attribute results in two DOMSubtreeModified events.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.