[Webkit-unassigned] [Bug 70904] Fix compilation of DFG JIT on PIC targets

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=70904


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #112483|review?                     |review-
               Flag|                            |




--- Comment #3 from Darin Adler <darin at apple.com>  2011-10-26 10:15:14 PST ---
(From update of attachment 112483)
View in context: https://bugs.webkit.org/attachment.cgi?id=112483&action=review

Contents of patch looks fine, but needs a new change log without tab characters and preferably with an explanation of the change too.

> Source/JavaScriptCore/dfg/DFGOperations.cpp:53
> +#if (OS(LINUX) || OS(FREEBSD)) && CPU(X86_64)
> +#define SYMBOL_STRING_RELOCATION(name) #name "@plt"
> +#elif OS(DARWIN) || (CPU(X86_64) && COMPILER(MINGW) && !GCC_VERSION_AT_LEAST(4, 5, 0))
> +#define SYMBOL_STRING_RELOCATION(name) "_" #name
> +#elif CPU(X86) && COMPILER(MINGW)
> +#define SYMBOL_STRING_RELOCATION(name) "@" #name "@4"
> +#else
> +#define SYMBOL_STRING_RELOCATION(name) #name
> +#endif

Can keep the size of this macro definition smaller by having it call SYMBOL_STRING in the #else case and removing one of the if cases?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.