[Webkit-unassigned] [Bug 70572] Refactor OptionsObject.cpp

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=70572


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #111890|review?                     |review+
               Flag|                            |




--- Comment #2 from Adam Barth <abarth at webkit.org>  2011-10-26 09:45:11 PST ---
(From update of attachment 111890)
View in context: https://bugs.webkit.org/attachment.cgi?id=111890&action=review

> Source/WebCore/bindings/v8/OptionsObject.h:54
> +    bool getKeyValue(const String&, bool&) const;
> +    bool getKeyValue(const String&, int32_t&) const;
> +    bool getKeyValue(const String&, double&) const;
> +    bool getKeyValue(const String&, String&) const;
> +    bool getKeyValue(const String&, ScriptValue&) const;

Why not just call these functions "get" ?

> Source/WebCore/bindings/v8/OptionsObject.h:61
> +    bool getKeyValueWithUndefinedOrNullCheck(const String&, String&) const;

getWithUndefinedOrNullCheck ?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.