[Webkit-unassigned] [Bug 70836] [chromium] add swapOut method to WebFrame

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=70836


Darin Fisher (:fishd, Google) <fishd at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #112395|review?                     |review-
               Flag|                            |




--- Comment #5 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2011-10-25 23:45:02 PST ---
(From update of attachment 112395)
View in context: https://bugs.webkit.org/attachment.cgi?id=112395&action=review

> Source/WebKit/chromium/src/WebFrameImpl.cpp:1059
> +void WebFrameImpl::swapOut()

I think this function belongs in the Chromium repository instead.  We should just
expose the necessary primitives through the WebKit API here.  For example, I think
it makes sense to have a WebDocument::create() function and a WebFrame::setDocument
function.  Perhaps WebFrame::setDocument can call m_frame->loader()->clear() before
changing the document?

Basically, the concept of "swapping out" doesn't belong in WebKit.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.