[Webkit-unassigned] [Bug 70491] Add mechanisms to notify WebCore of showing and dismissing context menu

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=70491


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #112334|review?                     |review-
               Flag|                            |




--- Comment #6 from Ryosuke Niwa <rniwa at webkit.org>  2011-10-25 07:58:05 PST ---
(From update of attachment 112334)
View in context: https://bugs.webkit.org/attachment.cgi?id=112334&action=review

I'd say r- due to various nits. How about win, mac, qt, etc...?

> Source/WebCore/ChangeLog:7
> +        Reviewed by NOBODY (OOPS!).

This line should appear before the description and blank lines before and after.

> Source/WebCore/ChangeLog:9
> +        No new tests. (OOPS!)

Please remove this line or explain why this change can't be tested.

> Source/WebKit/chromium/ChangeLog:8
> +        Reviewed by NOBODY (OOPS!).

Again this line should appear above the description and a blank line.

> Source/WebKit/chromium/public/WebView.h:328
> +    virtual void didCloseContextMenu() { }

Shouldn't this be a pure virtual function?

> Source/WebKit/gtk/ChangeLog:8
> +        Reviewed by NOBODY (OOPS!).

Ditto.

> Source/WebKit/gtk/webkit/webkitwebview.cpp:320
> +    HitTestResult result = controller->hitTestResult();
> +
> +    Node* node = result.innerNonSharedNode();
> +    if (!node)
> +        return;

Why do we need to hit-test?

> Source/WebKit/gtk/webkit/webkitwebview.cpp:321
> +    sleep(1000);

Where did this sleep(1000); come from?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.