[Webkit-unassigned] [Bug 70404] [EFL] Implement port layer of keygen element.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=70404





--- Comment #12 from Dongwoo Joshua Im <dw.im at samsung.com>  2011-10-24 21:13:03 PST ---
(In reply to comment #10)
> (In reply to comment #9)
> > (In reply to comment #5)
> > > (From update of attachment 111579 [details] [details] [details])
> > > View in context: https://bugs.webkit.org/attachment.cgi?id=111579&action=review
> > 
> > > > Source/WebCore/platform/efl/SSLPrivateKeyStoreEfl.cpp:35
> > > > +static SSLPrivateKeyStoreEfl* s_SSLPrivateKeyStoreEfl = 0;
> > > > +static Mutex s_SSLPrivateKeyStoreMutex;
> > > 
> > > These can be declared inside SSLPrivateKeyStoreEfl::getInstance() below, using the DECLARE_STATIC_LOCAL() macro.
> > 
> > I can't find "DECLARE_STATIC_LOCAL()" macro in WebKit source code.
> > Do you mean I need to define that kind of macro and use it?
> 
> You can reference history and sample in http://trac.webkit.org/changeset/91171

I use the static variables because I use singletone pattern here.

If I use the "DEFINE_STATIC_LOCAL" macro,
source code might look like this.

SSLPrivateKeyStoreEfl* SSLPrivateKeyStoreEfl::getInstance()
{
    DEFINE_STATIC_LOCAL(SSLPrivateKeyStoreEfl, s_SSLPrivateKeyStoreEfl, ());
    return &s_SSLPrivateKeyStoreEfl;
}

I don't understand deeply about DEFINE_STATIC_LOCAL, 
is it secure enough for singtone??

Or, do I need to make it as critical section?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.