[Webkit-unassigned] [Bug 70761] [chromium] Add category and TraceValue support to TraceEvent

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=70761





--- Comment #4 from John Bates <jbates at google.com>  2011-10-24 15:46:20 PST ---
(In reply to comment #3)
> I'm confused about the purpose of platformARgument. Why not just return a bool* from chromium, then use that where chromium macros typically use a TraceCategory*?

The TraceEvent class contains the TraceCategory pointer. Technically we could compute the TraceCategory pointer from the bool pointer, but I'm pretty sure I would be fired for even trying to get that past reviewers ;)

> 
> How will you pass the TraceValue struct out without copying? That's the bit that stumped me.

The platform glue code (chromium side impl of PlatformTraceProvider) would need to manually convert between the WebKit::TraceVaue and the base::debug::TraceValue. It would be great if we could just cast one to the other. The manual procedure is just to be safe in the event that the WebKit-side TraceValue becomes out of sync with the chromium version.

Another question is whether we can put PlatformTraceProvider in a common WebKit directory so that we can trace everywhere (not just chromium platform code).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.