[Webkit-unassigned] [Bug 70565] HashMap should support OwnPtr
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Oct 24 15:27:53 PDT 2011
https://bugs.webkit.org/show_bug.cgi?id=70565
--- Comment #3 from Adam Klein <adamk at chromium.org> 2011-10-24 15:27:52 PST ---
There's more trouble here than just porting over VectorTraits<OwnPtr> to HashTraits<OwnPtr>. Besides needing to teach HashTable how to copy an OwnPtr, the interface would also need to be tweaked to do the OwnPtr -> raw ptr or OwnPtr -> PassOwnPtr conversion. For example, some problematic methods:
MappedType get(const KeyType&) const;
MappedType take(const KeyType&);
pair<iterator, bool> set(const KeyType&, const MappedType&);
pair<iterator, bool> add(const KeyType&, const MappedType&);
All of these present some problems if MappedType were to be OwnPtr<T>, problems that aren't present in Vector<OwnPtr<T> > due to the latter's use of references and pointers in its interface.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list