[Webkit-unassigned] [Bug 70634] Set the opaque flag for GraphicsLayer.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=70634





--- Comment #6 from Adrienne Walker <enne at google.com>  2011-10-24 09:35:35 PST ---
(In reply to comment #5)
> (In reply to comment #4)
> > (From update of attachment 112004 [details] [details])
> > It's possible for multiple layers to go into the same backing, so I think you'll need some sort of bounds check of the layer vs. the bounds of the backing to make sure that a layer with an opaque background color fills the whole space.
> 
> Why is this needed? The opaque flag is being set for a single /layer/, and I don't understand why that is incorrect when the layer doesn't fill a backing.  Unless you want to add an opaque flag to the backing? Just for testing?

RenderLayer has an n->1 relationship with RenderLayerBacking.  RenderLayerBacking has a 1-1 relationship with GraphicsLayer.

You're checking the style of a RenderObject for the RenderLayer that was composited and setting a flag on the GraphicsLayer for that RenderLayer's RenderLayerBacking.  Because there's an n->1 relationship along that path, I don't think what you're checking is sufficient.

The owning RenderLayer for the RenderLayerBacking could have RenderLayer descendants that go into the same backing.  Those descendants might not be opaque and might not be contained within the bounding box of the owning RenderLayer.  Maybe take a look at RenderLayerCompositor::calculateCompositedBounds to see what I'm trying to get at.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.