[Webkit-unassigned] [Bug 70110] [Qt] fast/events/media-focus-in-standalone-media-document.html fails

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=70110


Simon Hausmann <hausmann at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #111954|review?, commit-queue?      |review+, commit-queue+
               Flag|                            |




--- Comment #6 from Simon Hausmann <hausmann at webkit.org>  2011-10-24 02:23:28 PST ---
(From update of attachment 111954)
View in context: https://bugs.webkit.org/attachment.cgi?id=111954&action=review

> Source/WebCore/platform/qt/MIMETypeRegistryQt.cpp:64
> +    { "mp4", "video/mp4" },
> +    { "m4v", "video/mp4" },
> +    { "m4a", "audio/x-m4a" },
> +    { "mp3", "audio/mp3" },
> +    { "ogv", "video/ogg" },
> +    { "oga", "audio/ogg" },
> +    { "ogm", "audio/ogg" },
> +    { "ogg", "audio/ogg" },
> +    { "webm", "video/webm" },
> +    { "webm", "audio/webm" },
> +    { "wav", "audio/wav" },
> +    { "mov", "video/quicktime" },

I think that this part is correct and badly needed :)

> Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp:666
> +    if (MIMETypeRegistry::isSupportedMediaMIMEType(type))
> +        return true;
> +

canShowMIMEType is called _after_ dispatchDecidePolicyForResponse. If DecidePolicyForResponse returns PolicyUse but canShowMIMEType suddenly would return false, then that
would sound like a bug to me. I think that is why for example the WK2 implementation always returns true and we probably should do the same in WK1. Your patch "improves" this
by increasing the probability of returning true ;-), but in the long run I wonder if canShowMIMEType should be removed from the FrameLoaderClient altogether?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.