[Webkit-unassigned] [Bug 70617] Optional "keytype" attribute for the <keygen> tag is handled incorrectly in appendFormData().

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=70617





--- Comment #12 from Darin Adler <darin at apple.com>  2011-10-23 21:09:06 PST ---
(In reply to comment #11)
> (In reply to comment #10)
> > However, to make that work I need to remove the following check from appendForm():
> > 
> > if (value.isNull())
> >   return false;
> > 
> > WebKit test runs (I tested this by building WebKit for chromium) seem to stub it out returning an empty String, causing the above check to fail.
> 
> If test runs returned an empty string, then that check would not fail. There is a distinct empty string and null string. If you want to change the stub to return an empty string instead of a null string, that’s OK with me. Making that change should not be difficult.

It occurs to me that for testing, it would be even better to change this to return some placing string that is helpful to interpret the test output rather than an empty string. That might be easy to do.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.