[Webkit-unassigned] [Bug 20795] text/plain form encoding ignored and incorrectly specified in request header

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Oct 23 18:58:45 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=20795





--- Comment #12 from Kent Tamura <tkent at chromium.org>  2011-10-23 18:58:45 PST ---
(From update of attachment 73453)
View in context: https://bugs.webkit.org/attachment.cgi?id=73453&action=review

>> WebCore/platform/network/FormData.h:98
>> +    static PassRefPtr<FormData> create(const FormDataList&, const TextEncoding&, const String encodingType = "application/x-www-form-urlencoded");
> 
> The encoding type definitely shouldn't be passed as string copy. Maybe String reference, maybe an AtomicString, or maybe an enum constant. The constant is probably most appropriate.

I agree with Alexey.  We had better introduce an enum set.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list