[Webkit-unassigned] [Bug 70617] Optional "keytype" attribute for the <keygen> tag is handled incorrectly in appendFormData().

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=70617





--- Comment #10 from Gaurav Shah <gauravsh at chromium.org>  2011-10-22 16:35:17 PST ---
Based on some pointers by abarth(thanks!), I added a regression test which uses the http server. Basically, it tests if the post request contains the <keygen> name= parameter. The test passes with the fix (and fails without). 

However, to make that work I need to remove the following check from appendForm():

if (value.isNull())
  return false;

As rsleevi mentioned in comment#7, signedPublicKeyAndChallenge() is a platform method whose implementation varies depending on the specific port in question. WebKit test runs (I tested this by building WebKit for chromium) seem to stub it out returning an empty String, causing the above check to fail. The POST is empty  (since the subsequent appendData() never gets called) and the test doesn't work.

Is this is a bad idea? An empty signedPublicKeyandChallengeString error should be handled by the server. I would argue that receiving an empty post request is worse (which happens now when keygen processing fails on the client) than receiving an empty "name= " POST (with this change).

Thoughts?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.