[Webkit-unassigned] [Bug 70679] [GTK] Build fixes for glib 2.31 (current master)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=70679


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #112088|review?                     |review-
               Flag|                            |




--- Comment #2 from Martin Robinson <mrobinson at webkit.org>  2011-10-22 08:30:47 PST ---
(From update of attachment 112088)
View in context: https://bugs.webkit.org/attachment.cgi?id=112088&action=review

> Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer.cpp:115
> +#if GLIB_CHECK_VERSION(2, 31, 0)
> +    g_cond_init(priv->data_cond);
> +    g_mutex_init(priv->buffer_mutex);
> +#else
>      priv->data_cond = g_cond_new();
>      priv->buffer_mutex = g_mutex_new();
> +#endif
>  }

This seems wrong. You are passing uninitialized pointers to g_cond_init. It seems like you'll need to allocate a GCond structure first. Please use the WTF allocator too. :) The same pattern should be used for the GMutex stuff.

Would it be easier to simply use WTF threading primitives here?

> Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer.cpp:253
> +#if GLIB_CHECK_VERSION(2, 31, 0)
> +        g_cond_clear(priv->data_cond);
> +#else
>          g_cond_free(priv->data_cond);

And here you would need to free the allocated data.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.