[Webkit-unassigned] [Bug 70404] [EFL] Implement port layer of keygen element.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=70404





--- Comment #10 from Ryuan Choi <ryuan.choi at samsung.com>  2011-10-22 01:05:36 PST ---
(In reply to comment #9)
> (In reply to comment #5)
> > (From update of attachment 111579 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=111579&action=review
> 
> > > Source/WebCore/platform/efl/SSLPrivateKeyStoreEfl.cpp:35
> > > +static SSLPrivateKeyStoreEfl* s_SSLPrivateKeyStoreEfl = 0;
> > > +static Mutex s_SSLPrivateKeyStoreMutex;
> > 
> > These can be declared inside SSLPrivateKeyStoreEfl::getInstance() below, using the DECLARE_STATIC_LOCAL() macro.
> 
> I can't find "DECLARE_STATIC_LOCAL()" macro in WebKit source code.
> Do you mean I need to define that kind of macro and use it?

You can reference history and sample in http://trac.webkit.org/changeset/91171

> 
> 
> > > Source/cmake/FindSSL.cmake:15
> > > +  NAMES openssl/ssl.h
> > 
> > It would be nice if a GNUTLS implementation were also provided, so that if GNUTLS is being used by the networking backend (by libcurl or libsoup), there's no need to link to both OpenSSL and GNUTLS libraries.
> 
> As I know, OpenSSL is the most popular and powerful open-source library which implements SSL.
> So, I think if we can use that, if there is no limitation to add new library, it's better to use OpenSSL rather than other library.
> 
> I think that's why Chrome implements keygen handler with OpenSSL.
> (As I know, Chromium offers 4 kinds of keygen handlers, which are 'win', 'mac', 'nss', and 'OpenSSL'.
> 'win' and 'mac' is platform specific, 'nss' is library from mozilla.)
> 
> What do you think?
> 
> 
> 
> > > Source/cmake/OptionsEfl.cmake:39
> > > +FIND_PACKAGE(SSL REQUIRED)
> > 
> > I'd rather not mark this as required, but condition it to a build-time option.
> 
> There is no option to enable/disable keygen. Keygen is always enabled.
> So, I think SSL library is required, if we use OpenSSL for keygen.
> 
> You have a lot more experience and knowledge about this than me, please let me know if I miss something.
> 
> 
> Thanks for your comments.

I also think that it's not good to provide openssl only.
However, this bug doesn't need to cover gnutls.

IMO, it's better to disable this feature when user doesn't have openssl, for now.

Leandro, how do you think about this?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.