[Webkit-unassigned] [Bug 70044] SVG Filter on a group doesn't invalidate when children are moved

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=70044





--- Comment #6 from Nikolas Zimmermann <zimmermann at kde.org>  2011-10-22 00:12:43 PST ---
(From update of attachment 112042)
View in context: https://bugs.webkit.org/attachment.cgi?id=112042&action=review

> Source/WebCore/rendering/svg/RenderSVGContainer.cpp:73
> +    if (m_everHadLayout) {
> +        if (selfNeedsLayout())
> +            SVGResourcesCache::clientLayoutChanged(this);
> +        else if(needsLayout())
> +            SVGResourcesCache::clientChildLayoutChanged(this);
> +    }

In general the idea looks sane to me. I'd propose to not do any selfNeedsLayout/needsLayout checks on the call site at all but leave that to clientLayoutChanged().

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.