[Webkit-unassigned] [Bug 69839] [Microdata] Add itemprop, itemref, itemvalue attributes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=69839





--- Comment #16 from Daniel Cheng <dcheng at chromium.org>  2011-10-22 00:07:11 PST ---
(From update of attachment 111854)
View in context: https://bugs.webkit.org/attachment.cgi?id=111854&action=review

Drive by... a couple nits.

> Source/WebCore/html/HTMLElement.cpp:205
> +    }  else if (attr->name() == itemrefAttr) {

Extra space

> Source/WebCore/html/MicroDataItemValue.cpp:38
> +namespace WebCore {

Newline here for consistency with the other files you added.

> Source/WebCore/html/MicroDataItemValue.h:50
> +    static PassRefPtr<MicroDataItemValue> createFromString(String);

Use a const reference.

> Source/WebCore/html/MicroDataItemValue.h:58
> +    MicroDataItemValue(String);

Use a const reference.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.