[Webkit-unassigned] [Bug 69410] [WK2] [GTK] Implement KeyDown function for WebKit2 EventSender.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=69410





--- Comment #13 from Kaustubh Atrawalkar <kaustubh at motorola.com>  2011-10-21 20:12:32 PST ---
(In reply to comment #12)
> (From update of attachment 111951 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=111951&action=review
> 
> Looks good, but I have a couple questions below.
> 
> > Tools/WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:63
> > +bool dispatchEvent(GdkEvent* event)
> > +{
> > +    gtk_main_do_event(event);
> > +    gdk_event_free(event);
> > +    return 0;
> > +}
> 
> This function should be static. Why does it return a bool, while you unconditionally return 0?
> 
Yes, I can make it static. I was returning bool only considering further more addition of Events like Mouse click/move/drag might add return values/error codes. 

> > Tools/WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:193
> > +    GdkKeymapKey* keys;
> > +    gint nKeys;
> > +    if (gdk_keymap_get_entries_for_keyval(gdk_keymap_get_default(), gdkKeySym, &keys, &nKeys)) {
> > +        pressEvent->key.hardware_keycode = keys[0].keycode;
> > +        g_free(keys);
> > +    }
> 
> Can you use GOwnPtr and .outPtr() for keys?

Yes, I will make that change.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.