[Webkit-unassigned] [Bug 69996] DFG should have inlining

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 21 18:13:37 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=69996





--- Comment #29 from Filip Pizlo <fpizlo at apple.com>  2011-10-21 18:13:36 PST ---
(In reply to comment #27)
> (From update of attachment 112050 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=112050&action=review
> 
> r=me
> 
> > Source/JavaScriptCore/dfg/DFGJITCompiler32_64.cpp:482
> > +        store32(Imm32(JSValue::CellTag), tagFor((VirtualRegister)(inlineCallFrame->stackOffset + RegisterFile::ScopeChain)));
> 
> So much sadness :-/

:-(

> 
> > Source/JavaScriptCore/runtime/Heuristics.cpp:32
> > -#define ENABLE_RUN_TIME_HEURISTICS 0
> > +#define ENABLE_RUN_TIME_HEURISTICS 1
> 
> Do we want these on by default?

Ooops!  Thanks for catching that!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list