[Webkit-unassigned] [Bug 70505] [GTK] [WK2] Memory leaks in WebContextGtk.cpp

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=70505


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #111792|review?                     |review-
               Flag|                            |




--- Comment #2 from Martin Robinson <mrobinson at webkit.org>  2011-10-21 13:23:55 PST ---
(From update of attachment 111792)
View in context: https://bugs.webkit.org/attachment.cgi?id=111792&action=review

Nice catch! Just a small suggestion below.

> Source/WebKit2/UIProcess/gtk/WebContextGtk.cpp:51
> +    return WTF::String::fromUTF8(databaseDirectory.get());

I know this was still an issue before, but do you mind using filenameToString from FileSystemGtk instead of fromUTF8 here? It's more correct.

> Source/WebKit2/UIProcess/gtk/WebContextGtk.cpp:63
> +    return WTF::String::fromUTF8(storageDirectory.get());

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.