[Webkit-unassigned] [Bug 70459] Page Scale Factor broken when navigating history on pages with child frames

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=70459





--- Comment #8 from Fady Samuel <fsamuel at chromium.org>  2011-10-21 08:17:26 PST ---
(In reply to comment #7)
> I think it is better to continue referring to this as page scale factor since that's what it is.  That it is stored on HistoryItem doesn't change the fact that it still acts like a page scale factor.  I think I'd just add a comment to HistoryItem indicating that the page scale factor field is ignored for subframes.

(In reply to comment #7)
> I think it is better to continue referring to this as page scale factor since that's what it is.  That it is stored on HistoryItem doesn't change the fact that it still acts like a page scale factor.  I think I'd just add a comment to HistoryItem indicating that the page scale factor field is ignored for subframes.

That's a fair short term solution. Ideally, I'd like to store the pageScaleFactor once per page. Simon Fraser told me to take a look at CachedPage to see if pageScaleFactor might belong there. I haven't looked at it yet, but I intend to investigate where would be a better place to store cached pages' pageScaleFactors...

Maybe that clean up effort should be logged as a separate bug...

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.